search

sgruhier / foundation_rails_helper

Rails Helper for Zurb Fondation framework
MIT License
153 stars 83 forks source link

Remove dependency on tzinfo gem #179

Closed werebus closed 3 years ago

werebus commented 3 years ago

Hello,

I was working on updating my app to Rails 6.1 and noticed that this gem's version dependency on the "tzinfo" gem was holding me back.

I couldn't see anything in the code that relied on tzinfo — doing some code archaeology, the dependency appears to have been added to keep compatibility with Rails 3 while adding Rails 4 support (and has been periodically bumped since then) — so, I removed the requirement.

While I was here, I updated the Travis config to include Rails 6.1, added Ruby 2.7 to the matrix where supported, and removed Rubies 2.1 and 2.2 which have been EOL for a few years now.

I also found some test failures in Rails 6.1 when using date_field, time_field, etc. with non-date attributes. Seemed like a thing a "real person" wouldn't do, so I just changed the test.

werebus commented 3 years ago

Thanks Sébastien for the merge.

Do you have time to do a gem release at some point? Not urgent; I've got my Gemfile pointed at the master branch for now.