search

sgs006 / Udacity-Yearbook-Project

Optional Yearbook Collaboration for Udacity Front-End Scholarship Participants
41 stars 39 forks source link

Updates to homepage and navbar #59

Closed rob9095 closed 6 years ago

rob9095 commented 6 years ago

Updated homepage with bootstrapped elements. Updated nav bar and container on all .html pages Updated index.css to use new styles for homepage Made small additions/changes to styles.css and rotating-cards.css

koolamusic commented 6 years ago

screenshot-2018-2-1 udacity-yearbook-project - codacy - pullrequests Hello Rob, codacy suggested some improvements to the quality of your PR, because of the use of a lot on !important tags in your index.css refer to the screenshot

You can have a look at CSS Specificity to see how you can avoid these errors and have your selector properties work well without forcing them with !important

sgs006 commented 6 years ago

I looked at the test code and some things are off from the mock-up. We need to hold off on this for right now. We are trying to get back to the drawing board on planning some of these features and making sure things are consistent.