search

sgs006 / Udacity-Yearbook-Project

Optional Yearbook Collaboration for Udacity Front-End Scholarship Participants
41 stars 39 forks source link

Made a few changes #82

Closed chrisvneal closed 6 years ago

chrisvneal commented 6 years ago

Hey all, no one answered me so I assumed this project was still "open source", here is just some commits to refactor CSS, handle minor issues like removing reboot.css since it it is already included in Bootstrap, and cleaned up a lot of dirty code that was lying around. If you don't include that's ok. Thanks for starting the project, it looks really fun!

chrisvneal commented 6 years ago

Also, I am not done everything. There is still the hamburger menu icon on large display so I haven't hooked that up to anything.

chrisvneal commented 6 years ago

Added a bit of jQuery to add some style to the resources page section and set an "interface" of sorts splitting the navigational menu and group items.

resources

chrisvneal commented 6 years ago

If you all didn't mind, I removed the fixed style from the footer because there's really non relevant information to keep prominent like that so it should stay put.

Also the best I could I gave index.html an "over the fold" style look

overthefold

I also managed to fix the hiding and visibility of the hamburger-icon. Anyone know how to hook up the drop down? I could try.

chrisvneal commented 6 years ago

I put fixed positioning back on footer, sorry. Does look rather nice

footersback

chrisvneal commented 6 years ago

I removed the 100% search on focus just to neaten up the area. We can easily add the styles back if you want the feature. I figured a simple search tool on the left side would fit for the page..

searchbar

chrisvneal commented 6 years ago

The menu (on mobile) could be styled better with smoother effects, but it is fully functional!

jamesperrin commented 6 years ago

Please only make pull requests for work you have been assigned. By submitting work that you were not assigned is robbing an opportunity from another Team Member, which is not nice or fair.

Refer: https://discussions.udacity.com/t/udacity-yearbook-student-project-fe-team-home-page/610818/54