Improve default semantics of `write_mesh`

sgsellan / gpytoolbox

A collection of utility functions to prototype geometry processing research in python

https://gpytoolbox.org

GNU General Public License v3.0

196 stars 16 forks source link

Improve default semantics of `write_mesh` #103

Closed abhimadan closed 10 months ago

abhimadan commented 10 months ago

Fixes #102. If UV coordinates or normals are provided, but the corresponding indices are not, and there are as many UV coords/normals as vertices, the vertex indices will be used as a default.

sgsellan commented 10 months ago

@odedstein , do you mind reviewing and approving this if necessary since you wrote the original function?

odedstein commented 10 months ago

@abhimadan I added a unit test for this behavior, as well as some docs (and an acknowledgement for you in the README.md). If you're ok with the changes, and they pass the tests, I will approve this PR.

abhimadan commented 10 months ago

The changes look great, thank you! I'll try to add documentation and unit tests next time I make a change.