search

sgsellan / gpytoolbox

A collection of utility functions to prototype geometry processing research in python
https://gpytoolbox.org
GNU General Public License v3.0
206 stars 15 forks source link

Switching out parameters in torus function #114

Closed odedstein closed 5 months ago

odedstein commented 9 months ago

This is in response to bug report #113 . The parameters nr and nR are switched in the torus.py function.

odedstein commented 9 months ago

@sgsellan do you think this is the correct change to make? Or should I have changed the names of the parameters in the function declaration, but kept the old order, so as to not break old code?

sgsellan commented 9 months ago

Mmmm yeah, now that you mention it, it may be a better idea to keep backwards compatibility with old code (otherwise if I remember our rule correctly, that'd mean that we can only merge this PR for the next major release, 0.3.0)

odedstein commented 9 months ago

I was just going to make the change, but then the new order of parameters nr,nR,R,r would be weird unless we also change the order at the end of R,r to r,R (another breaking change). Let's maybe just wait with merging this until we do 0.3.0 - it's a minor fix that should not be too hard to merge.

sgsellan commented 9 months ago

Sounds good to me then! Let's wait to merge this