search

sgsellan / gpytoolbox

A collection of utility functions to prototype geometry processing research in python
https://gpytoolbox.org
GNU General Public License v3.0
196 stars 16 forks source link

adding DEC operators #116

Closed odedstein closed 4 months ago

odedstein commented 6 months ago

This pull request adds DEC operators in the style of https://www.cs.cmu.edu/~kmcrane/Projects/DDG/

@sgsellan I'd be glad if you could double check to make sure I did these correctly :)

odedstein commented 5 months ago

I don't care whether we have separate files for this or not, I have no strong feelings. You can decide.

sgsellan commented 5 months ago

See typo above. We did not catch that typo due to a bigger problem: unless I am missing something, currently, the inv functions (intrinsic and not) have no unit test. I do feel strongly about this rule: if a function is included in __init__.py (i.e., can be imported as gpytoolbox.function_name), it should have a unit test.

odedstein commented 5 months ago

Good point. Will fix this and add unit tests.

sgsellan commented 4 months ago

This looks good to me now! Happy to merge