sgsellan / gpytoolbox

A collection of utility functions to prototype geometry processing research in python
https://gpytoolbox.org
GNU General Public License v3.0
196 stars 16 forks source link

adding triangulation and tetrahedralization functions #118

Closed odedstein closed 5 months ago

odedstein commented 5 months ago

This PR adds triangulation and tetrahedralization capacity.

For triangulation, this uses CDT. This is, in my opinion, better than Shewchuck's classic Triangle for 3 reasons:

For tetrahedralization, this uses TetGen through its libigl wrapper.

It's still not quite ready to merge before we discuss 2 important points:

sgsellan commented 5 months ago

There seems to already exist a great python wrapper for tetgen, with a good API that is similar to ours. So I personally do not think the damage of polluting the license is offset by any gain of having it wrapped in our library, at least right now. So I propose we excise the tetrahedralization from this PR.

On triangulation, I am happy to learn about this library! Seems to do what I use triangle for, but better. Happy to both merge now, and merge once their refinement PR is merged. Up to you.

odedstein commented 5 months ago

Your point makes sense to me. Let's leave off this pull request for now, and revisit it when the triangulation library is more mature.