search

sgsinclair / Voyant

GNU General Public License v3.0
208 stars 53 forks source link

correlations should include p values #415

Open sgsinclair opened 6 years ago

sgsinclair commented 6 years ago

from an email from Nathan Craig

sgsinclair commented 6 years ago

We've changed the way correlations are calculated. Previously we were using the PearsonsCorrelation class from Apache Commons Math, but that couldn't provide us p values directly. However, the underlying implementation was using the SimpleRegression class, which does have a [method to get significance](http://commons.apache.org/proper/commons-math/javadocs/api-3.3/org/apache/commons/math3/stat/regression/SimpleRegression.html#getSignificance()).