search

sgsinclair / Voyant

GNU General Public License v3.0
207 stars 53 forks source link

cancel Spyral.Load.files() #489

Closed sgsinclair closed 4 years ago

sgsinclair commented 4 years ago

running Spyral.Load.files() produces a spinning wheel and a (overly subtle) link to Choose a file or drag and drop, but there doesn't seem to be a good way of cancelling out of there. Could the working spinner be accompanied somewhere in close proximity to some mechanism to cancel? It may not be possible (and it may be very rarely needed), but still.

I note that even pressing the close x doesn't hide the spinning wheel.

ajmacdonald commented 4 years ago

The close button now rejects the promise, which removes the spinning wheel.

https://github.com/sgsinclair/voyantjs/commit/f04a7095b3d650496e1a36d27d1ce3b07ae2d837