sgsinclair / trombone

GNU General Public License v3.0
14 stars 6 forks source link

Add hebrew stop words list #24

Closed sarnov closed 3 years ago

sarnov commented 3 years ago

@ajmacdonald as you suggested in: https://github.com/sgsinclair/Voyant/issues/532

ajmacdonald commented 3 years ago

Thank you @sarnov I see from the comment that you based the list on one from stopwords-iso, and have edited it slightly. Since I don't understand Hebrew, would you mind explaining the changes that you made?

sarnov commented 3 years ago

@ajmacdonald Thanks for reviewing. I removed 16 words that I thought were not really stop words, mostly words that were a conjunction of two words. I didn't add anything. Do you want me to detail something here or in the file itself?

ajmacdonald commented 3 years ago

@sarnov I think you've given enough detail here. Thanks again.