search

sgtaziz / WebMessage

A client for communicating with the WebMessage tweak on iOS. Send and receive messages from the comfort of your computer
72 stars 12 forks source link

[Feature Request] Contact photos in notifications #110

Closed sabogalc closed 3 years ago

sabogalc commented 3 years ago

So I'm not sure what the best way to implement this would be. Text-message-alert-notification-with-Actions-button That is how a notification shows up for an individual macOS chat, and on my Mac with Mojave, in group chat notifications it gives the photo of the person who sent the message. On Big Sur, I'm not sure if this is still what happens or if the group chat photo is what's shown instead, Messages-you-were-mentioned-in-this-chat There's another sample image I found, so maybe in instances like that, the normal WebMessage icon notification could still work. 110244024-d4c58300-7f2a-11eb-9283-89f9eb83bdad I was thinking that the WebMessage icon in the top left can always stay, and then the other one just becomes the contact image. And if there is no contact image, should it default to the avatar, or to the WebMessage icon? And, if it is a group chat notification, could it be made so that the top left icon is the group chat photo and the big one is the photo of the individual who sent the message? And then of course there could be problems if either the group chat doesn't have a photo or the contact doesn't.

I'm not sure what the best way to implement this would be, so I think the request needs a little work, but hopefully what I said makes some sense.

sabogalc commented 3 years ago

image So here is how the same notification from a group chat loaded for me on Mojave in both WebMessage and Messages. I don't have a computer with Big Sur, but I think that would be good to test too. The Messages notification has both the app icon and the contact image, which I think is a good blend. Screen Shot 2021-03-07 at 11 26 15 AM Also, going into the notification details gave me a glitched icon, like in issue #109. I'm not sure if this is specific to me or my OS, or if it affects all of the macOS builds. Also, what is the minimum macOS version required to run the WebMessage client? And the minimum Windows version?

sabogalc commented 3 years ago

Thank you for implementing this (and so much more) in the 0.6.1 update! I know this is still a work in progress, especially in macOS, but I have two things to say. descriptive I think the notifications used to display "Tommy loved an image" or "Joseph emphasized [text]". Is this a limitation with a new way of fetching notifications? And for contacts with no contact photo, would it be possible to display their initials avatar? Or is that avatar not actually saved anywhere as an image file? Thank you again for the amazing updates 👍

sgtaziz commented 3 years ago

Thank you for the kind words! Having initials is unfortunately not possible at the moment, since the avatar is just CSS/HTML without any images. But I might be able to generate them on the fly, I'll check! The text is something I overlooked actually, will be fixed in the next update 👍

shawnk0723 commented 1 year ago

So I'm not sure what the best way to implement this would be. Text-message-alert-notification-with-Actions-button That is how a notification shows up for an individual macOS chat, and on my Mac with Mojave, in group chat notifications it gives the photo of the person who sent the message. On Big Sur, I'm not sure if this is still what happens or if the group chat photo is what's shown instead, Messages-you-were-mentioned-in-this-chat There's another sample image I found, so maybe in instances like that, the normal WebMessage icon notification could still work. 110244024-d4c58300-7f2a-11eb-9283-89f9eb83bdad I was thinking that the WebMessage icon in the top left can always stay, and then the other one just becomes the contact image. And if there is no contact image, should it default to the avatar, or to the WebMessage icon? And, if it is a group chat notification, could it be made so that the top left icon is the group chat photo and the big one is the photo of the individual who sent the message? And then of course there could be problems if either the group chat doesn't have a photo or the contact doesn't.

I'm not sure what the best way to implement this would be, so I think the request needs a little work, but hopefully what I said makes some sense.

Hey @CSab6482, is your notification working now?