sgtcaze / NametagEdit

Simple plugin to give players custom nametags
GNU General Public License v3.0
194 stars 132 forks source link

Console error due to placeholder #841

Open WarriorLlama opened 1 year ago

WarriorLlama commented 1 year ago

Bug Report

Type /ver NametagEdit and post the output.

NametagEdit version 4.5.14

What version of Bukkit/Spigot/PaperSpigot are you using? Type /ver

This server is running Paper version git-Paper-367 (MC: 1.19.3) (Implementing API version 1.19.3-R0.1-SNAPSHOT) (Git: 51cfcc8)

What plugins are you using? Type /plugins

Plugins (31): Brewery, Citizens, CoreProtect, CraftBook, Essentials, EssentialsSpawn, GSit, Heroes, LuckPerms, luckperms-rpkit-bridge*, LWC, Multiverse-Core, Multiverse-Portals, NametagEdit, PlaceholderAPI, ProtocolLib, rpk-character-lib-bukkit, rpk-characters-bukkit, rpk-chat-bukkit, rpk-chat-lib-bukkit, rpk-core-bukkit, rpk-drink-lib-bukkit, rpk-language-lib-bukkit, rpk-languages-bukkit, rpk-permissions-lib-bukkit, rpk-player-lib-bukkit, rpk-players-bukkit, rpk-rolling-bukkit, Vault, WorldEdit, WorldGuard

Please explain your issue. How do you trigger it?

I added a placeholder as a suffix into NameTagEdit for my username. After logging out, an error appears in the server console log. The nametag seems to work fine in-game. The placeholder I am using is from the RPKit plugin, which allows you to create a name for your character with %rpkcharacters_charactername%. I linked this to NameTagEdit with:

Name: WarriorLlama
Prefix: '&2%rpkcharacters_charactername% | &7'
Suffix: ''
SortPriority: -1

Are there any errors in the console? Please use: https://pastebin.com

https://pastebin.com/WYWJExRg

ChimpGamer commented 1 year ago

Your issue is caused by the rpk-characters-bukkit plugin. On this line in the plugin: https://github.com/RP-Kit/RPKit/blob/main/bukkit/rpk-characters-bukkit/src/main/kotlin/com/rpkit/characters/bukkit/placeholder/RPKCharactersPlaceholderExpansion.kt#L34 they defined player as not null and it should be nullable and that is causing the error. Get in contact of the plugin developer and let them fix the issue.

WarriorLlama commented 1 year ago

Thank you for getting back to me, I have let the plugin developer know! :)