sgwilym / nova-deno

A Deno extension for Nova.
https://extensions.panic.com/extensions/co.gwil/co.gwil.deno/
MIT License
13 stars 1 forks source link

Some code actions don't work #1

Closed sgwilym closed 8 months ago

sgwilym commented 2 years ago

It seems that most code actions don't work. Nova's LanguageClient probably isn't able to handle the result, and I've logged the issue here.

jaydenseric commented 2 years ago

Is this issue tracking this problem, where the cache code action does work and results in extension console errors?

Screen Shot 2021-08-03 at 12 02 02 pm
sgwilym commented 2 years ago

Yup. Basically all code actions don't work right now. For now, you'll need to cache using 'Cache dependencies' command from the command palette.

sgwilym commented 2 years ago

Fixed in Nova 9.

belcar-s commented 2 years ago

Code actions still don't seem to work for me 🙁. I'm using Nova 9.3.

https://user-images.githubusercontent.com/73370025/163695356-18f73de0-6187-497b-a3a0-6cc0acdaf452.mov

The TypeScript extension almost achieves it:

https://user-images.githubusercontent.com/73370025/163695401-f6cf8c4c-1013-48e8-9bc5-774bd04b4e2e.mov

sgwilym commented 2 years ago

I've also noticed some weirdness around this, because some code actions work - like adding a missing import. I think I'll have to do some digging here, and I have a feeling this might need changes from Nova's side too, so bear with me.

belcar-s commented 2 years ago

Here are some messages I got after trying to cache a dependency:

Screen Shot 2022-04-21 at 12 33 41 PM Screen Shot 2022-04-21 at 12 34 01 PM

I disabled the extension and one of these errors began appearing in the console every time I changed the cursor's position:

Screen Shot 2022-04-21 at 12 36 05 PM
sgwilym commented 8 months ago

Superseded by #31