search

sgwilym / nova-deno

A Deno extension for Nova.
https://extensions.panic.com/extensions/co.gwil/co.gwil.deno/
MIT License
13 stars 1 forks source link

Add support for enablePaths LSP option #21

Closed sgwilym closed 8 months ago

sgwilym commented 2 years ago

A new option was added in Deno 1.21 for path specific enabling: https://deno.com/blog/v1.21#enable-extension-in-subpaths-of-the-workspace

This would be fairly easy to add as a per-project setting.

belcar-s commented 2 years ago

How are the paths sent to the server? I wish this software were documented (or, if it is documented, that I could find the documentation) :slightly_frowning_face:. I've seen a super mysterious tsApi be used, but, since it's super mysterious, that hasn't really helped.

sgwilym commented 2 years ago

This would be an option we'd pass to the client upon initialisation, here: https://github.com/sgwilym/nova-deno/blob/main/src/client_disposable.ts#L119

sgwilym commented 11 months ago

This does indeed not yet work. :/ But I've opened an issue over at the Deno repo: https://github.com/denoland/deno/issues/19802

There's a possibility that the aggressive escaping which Nova's built-in LSP client does is messing with things.