Reducing the frequency of reloading

sgwilym / nova-deno

A Deno extension for Nova.

https://extensions.panic.com/extensions/co.gwil/co.gwil.deno/

MIT License

14 stars 1 forks source link

Reducing the frequency of reloading #38

Open belcar-s opened 2 years ago

belcar-s commented 2 years ago

These changes greatly alleviate issue #35. The tree view is now only reloaded…

when its symbols' names are changed and
when symbols are added or removed.

https://user-images.githubusercontent.com/73370025/173280198-62afb47e-3372-4b16-a161-438f95adef82.mp4

I think that this, together with a solution for the onDidStopChanging problem, would enable us to provide a very pleasant experience with the sidebar.

belcar-s commented 2 years ago

I'm going to remove some of SymbolDataProvider's properties and store the needed information in File objects instead.

belcar-s commented 2 years ago

I would love some help (after the holiday, of course!) in getting the elements' identifiers to work. Even when I set them to a constant, files in the sidebar are expanded immediately after the TreeView is reloaded.

sgwilym commented 2 years ago

@belcar-s Do you think this issue is something we can fix, or is this something specific to Nova?

belcar-s commented 2 years ago

The identifier issue, I'm not sure. I made a post on the DevForum about it, but it wasn't replied-to. It's very possible that it's my fault, and that I'm misusing the field.