Open belcar-s opened 2 years ago
I don't know how to use this RegExp, which I found in the doowb/ansi-colors source code, without committing copyright infringement/becoming a criminal, and getting sent to jail.
/[\u001b\u009b][[\]#;?()]*(?:(?:(?:[^\W_]*;?[^\W_]*)\u0007)|(?:(?:[0-9]{1,4}(;[0-9]{0,4})*)?[~0-9=<>cf-nqrtyA-PRZ]))/g
It's seemingly licensed MIT. Do I add the thing to the LICENSE
file, or is it OK to add the disclaimer next to the copied line? Sorry 🙁.
Wow! This is nearly done. I think I overestimated the difficulty. (Watch me turn out incapable of doing the rest 🙂.)
Note that we currently obtain the test results by parsing the logging produced by Deno, which must be prone to change. I'd love to know of a better way to do this.
Things remaining:
dolor.test.ts
's outcomes from appearing (.test.ts
is empty and this is in reference to the video)Ideas:
The Deno process's exit code upon failure is the same, regardless of whether the issue is a test's failure or failure to run tests. I can't think of an easy way, for example, of detecting the lack of a needed import map and notifying the user about it.
It might have been a bad idea to squash the changes from the other branches into 247786bcee22a3e1d29695b0e14ee2d53cec4d5c because I think that the commit will be kept now. I don't know how to undo that 🙁.
In regard to the hidden section above, see https://devforum.nova.app/t/a-fun-new-way-to-crash-the-extension-service/1682.
I'm going to try to make it show test results as they come, and I'll make it notify that tests couldn't be run even if the attempt was made through a context menu.
The particular change I made in order to enable the first of those two things made test-running much slower, and I'm not really so enthusiastic about trying again, so I'll leave that as it is 🙃.
This pull request is based on my two other branches:
minimal-changes
andexcessive-reloading
. I can rebase it if those changes are rejected. If they aren’t rejected, though, doing so is not a good idea; it would involve tons of conflict resolution (I think?) that would later need to be reversed. (The commit history and diffs in this page would supposedly be updated if the other pull requests were merged.)Like last time, icons are missing. We need a
test_sidebar_large
, atest_sidebar_small
and arun
. Therun
is for the Run All button. I think an icon is better than a label, but we can use a label if that's preferred :).https://user-images.githubusercontent.com/73370025/175392362-cb580c7a-4f6a-404c-802d-74d5bfc5f61b.mp4
The above video showcases an older version of the feature. In the current version, a warning is shown the first time the user runs tests in each workspace. The notification that is displayed after three seconds of the tests running could become annoying; it would be good to allow it to be disabled.
Changes unique to this pull request begin at Define the sidebar.