search

sgwilym / nova-deno

A Deno extension for Nova.
https://extensions.panic.com/extensions/co.gwil/co.gwil.deno/
MIT License
14 stars 1 forks source link

Remove ability to send network requests? #7

Closed atdrendel closed 3 years ago

atdrendel commented 3 years ago

Is there a reason why the extension needs to be able to send network requests?

sgwilym commented 3 years ago

@atdrendel I put this in here because this extension is able to send a 'cache' command which instructs Deno to cache all remote dependencies (and so triggering some network requests). But you've made me think that this is something Deno does rather than this extension, so maybe it's safe to remove this...?

sgwilym commented 3 years ago

As of v0.2 I've removed this entitlement as it doesn't seem this extension needs it to work. :)

atdrendel commented 3 years ago

Awesome. Thanks a lot for taking care of it, and thanks for working on this extension. I'm a big fan.