Linting not working - Githubissues

sgwilym / nova-deno

A Deno extension for Nova.

https://extensions.panic.com/extensions/co.gwil/co.gwil.deno/

MIT License

14 stars 1 forks source link

Linting not working #8

Closed jaydenseric closed 3 years ago

jaydenseric commented 3 years ago

In a project with a mix of .js and .jsx files, no lint warnings or errors appear in the editor if you do mistakes, e.g. bad syntax.

In VS Code using the official Deno extension such lint errors are reported in the editor, so I don't think it's a problem with my Deno project.

I haven't tried .ts or .tsx files yet with Nova and this extension, so I don't know if they lint as expected.

jaydenseric commented 3 years ago

Ok, linting is not working for .ts files either:

Does it need to be enabled somehow?

I'm using the latest Deno, and the CLI is installed:

$ deno --version
deno 1.12.2 (release, x86_64-apple-darwin)
v8 9.2.230.14
typescript 4.3.5

jaydenseric commented 3 years ago

Possible clues...

When I open a Nova Deno project with an open .js file, here is what appears in the extension console:

With a .jsx file:

jaydenseric commented 3 years ago

Issue persists after downgrading Deno to the version mentioned in the extension readme:

deno upgrade --version 1.10.3

sgwilym commented 3 years ago

I think I've fixed this in v0.2 when I refactored user configurations. It should be up in the extension library soon, so let me know if it fixes the issue for you.

sgwilym commented 3 years ago

@jaydenseric Are you still having this problem?

jaydenseric commented 3 years ago

I think this is working now, thanks for your work :)

I've been on Node.js projects the past few days, but am back on Deno work again now so I'll be able to try out the fix more thoroughly. I did notice the other day the linting wasn't working for a bit, but I managed to coax it into working again by restarting the editor or something, I can't remember. If it happens again I'll report back.