search

sgzijl / lvmconfig

Configure LVM with data from hiera
0 stars 1 forks source link

Remove restriction on specifying size in MB. #5

Closed hyclak closed 9 years ago

hyclak commented 9 years ago

Not sure if there was a reason you forced file sizes in MB, but from looking at the code it doesn't appear that there's any reason not to allow all valid suffixes. I started with the acceptable values from the lvcreate man page, however realized that the puppetlabs-lvm module had tighter restrictions so I went with their (slightly modified) regex to validate $size.

hyclak commented 9 years ago

I should say that I tested this with values like 0.5T, 1G, 100M and they all worked as expected.

sgzijl commented 9 years ago

Probably historical reasons, but puppetlabs-lvm evolved over time. I can confirm 0.5T, 1G, 100M all seem to work fine. Let's merge this finding and awesome improvement. Thanks!