sh-lee97 / grafx

GRAFX: An Open-Source Library for Audio Processing Graphs in PyTorch
https://sh-lee97.github.io/grafx/
Apache License 2.0
82 stars 6 forks source link

Cannot import grafx, modules are missing #5

Closed p4thie closed 2 hours ago

p4thie commented 4 hours ago

Description

Cannot import grafx because of missing modules, namely torchaudio and scipy.

How to reproduce

  1. Install grafx by running pip install grafx (or, git clone https://github.com/sh-lee97/grafx then pip install -e . )
  2. import grafx via python REPL (for the sake of minimal reproduction)
  3. ModuleNotFoundError: No module named 'torchaudio'. Even if you have torchaudio installed, ModuleNotFoundError: No module named 'scipy' gets raised.

Expected behavior

Should be able to import grafx without manually resolving dependencies afterward.

How to fix

Environment

Python 3.10.12, Ubuntu 22.04

p4thie commented 3 hours ago

Created draft pull request https://github.com/sh-lee97/grafx/pull/6

sh-lee97 commented 2 hours ago

Oops, my bad. Sorry for the inconvenience and thanks for raising the issue! We approved your PR. We are working on the GitHub workflows to automatically test and detect such issues - we will finalize this asap.