sh1nobuu / BitAnime

A Python script that allows you to download all of an anime's episodes at once.
23 stars 10 forks source link

[Feature Request] Able to Select Video Quality when Downloading #3

Closed NevGi-cpu closed 2 years ago

NevGi-cpu commented 3 years ago

I always download animes in 480p. Because of not having enough storage on my pc. I tried many other scripts like anime-dl and others available on Github. Most of them are outdated and don't work on the websites they tell it will. And even if it works I can't download the videos of my choosing quality.

sh1nobuu commented 3 years ago

Hello, thank you for your suggestion! I'll work on that after finishing the feature that I will be soon finished (removing the 1 to 99 episodes limit).

sh1nobuu commented 2 years ago

I always download animes in 480p. Because of not having enough storage on my pc. I tried many other scripts like anime-dl and others available on Github. Most of them are outdated and don't work on the websites they tell it will. And even if it works I can't download the videos of my choosing quality.

Hi! I added the feature that will let you choose the episode quality if you're interested on trying it out you can find it here https://github.com/sh1nobuu/BitAnime/tree/feature/dynamic-episode-quality (Not yet optimized. The optimize version will be out tom.) Thanks!

NevGi-cpu commented 2 years ago

Yes, I'm very much looking forward to trying it. But, I just have to ask will you be maintaining this project in the future too. Since there is so many projects much like this which was good at first but after some time it was left stagnant.

sh1nobuu commented 2 years ago

Yes, I'm very much looking forward to trying it. But, I just have to ask will you be maintaining this project in the future too. Since there is so many projects much like this which was good at first but after some time it was left stagnant.

Yes, I'm planning on maintaining this script since I use this script a lot too so you don't need to worry about it being outdated.

NevGi-cpu commented 2 years ago

Hey i can't use git clone to install bitanime and I also can't install requirements using pip install commands you gave

sh1nobuu commented 2 years ago

Hey i can't use git clone to install bitanime and I also can't install requirements using pip install commands you gave

Can you paste here the error?

NevGi-cpu commented 2 years ago

For Bitanime :

PS C:\Windows\system32> git clone https://github.com/sh1nobuu/BitAnime.git Error: git : The term 'git' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again. At line:1 char:1

For Requirements:

PS C:\Windows\system32> pip install -r requirements.txt Error: ERROR: Could not open requirements file: [Errno 2] No such file or directory: 'requirements.txt'

sh1nobuu commented 2 years ago

For Bitanime :

PS C:\Windows\system32> git clone https://github.com/sh1nobuu/BitAnime.git Error: git : The term 'git' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again. At line:1 char:1

For Requirements:

PS C:\Windows\system32> pip install -r requirements.txt Error: ERROR: Could not open requirements file: [Errno 2] No such file or directory: 'requirements.txt'

Are you sure you have git install in your pc? You can't install requirements txt if you can't clone the file. An already way to download it is download the zip version.

NevGi-cpu commented 2 years ago

yes i have installed git using choco. image

sh1nobuu commented 2 years ago

yes i have installed git using choco. image

Have you tried cloning other repo? because from what i can see your system can't recognized git as a command

NevGi-cpu commented 2 years ago

Seems like I needed to refresh the env now i cloned repo but pip still not working image

sh1nobuu commented 2 years ago

Seems like I needed to refresh the env now i cloned repo but pip still not working image

after cloning the repo you need to cd to the BitAnime folder

sh1nobuu commented 2 years ago

And if you want to use the script with dynamic script you need to clone the feature/dynamic-episode-quality branch

NevGi-cpu commented 2 years ago

How do i do that? I tried this: image

sh1nobuu commented 2 years ago

How do i do that? I tried this: image

if you want to clone a specific branch you can follow this command: "git clone -b feature/dynamic-episode-quality --single-branch https://github.com/sh1nobuu/BitAnime.git" after cloning the repo cd to the folder cd BitAnime then "pip install -r requirements.txt"

NevGi-cpu commented 2 years ago

image

Already installed requirements

sh1nobuu commented 2 years ago

image

Already installed requirements

The BitAnime folder already exist in your system try deleting it and then run the command again.

NevGi-cpu commented 2 years ago

image Now is everything ready? Do I just download and run bitanime.exe or can I run it through PowerShell. How to choose video quality when downloading

sh1nobuu commented 2 years ago

image Now is everything ready? Do I just download and run bitanime.exe or can I run it through PowerShell. How to choose video quality when downloading

image for the quality, you have 4 option: 1: 360p, 2: 480p, 3: 720p, 4: 1080p.

NevGi-cpu commented 2 years ago

Download not starting image

sh1nobuu commented 2 years ago

Download not starting image

wait for it the site is quite slow to respond therefore the downloading is slow

NevGi-cpu commented 2 years ago

There was a Vinland Saga folder created and 5 eps downloaded but their size was 60mb and only the first 5min part of the video was playable.

NevGi-cpu commented 2 years ago

It already closed the .exe after that i found above

sh1nobuu commented 2 years ago

It already closed the .exe after that i found above

seems like the code is broken let me check

sh1nobuu commented 2 years ago

I'll mention you after I'm done patching it.

NevGi-cpu commented 2 years ago

Ok

NevGi-cpu commented 2 years ago

Just so you don't misunderstand. I closed the .exe myself. And after that i found the anime folder.

NevGi-cpu commented 2 years ago

I tried again and yes although the progress bar isn't moving the size of episode is increasing I think it's working.

sh1nobuu commented 2 years ago

I tried again and yes although the progress bar isn't moving the size of episode is increasing I think it's working.

Thanks for the info man seems like the site itself is at fault, I'm having a hard time downloading an episode with a 360P quality

NevGi-cpu commented 2 years ago

The download is working. image I want to change the default dir where the anime is downloaded. How can I do it

sh1nobuu commented 2 years ago

The download is working. image I want to change the default dir where the anime is downloaded. How can I do it You can do that by modifying the code in bitanime.py

sh1nobuu commented 2 years ago

The download is working. image I want to change the default dir where the anime is downloaded. How can I do it

""" Create a download folder for the anime """ folder = os.path.join(insert-your-path-here , title) if not os.path.exists(folder): os.mkdir(folder)

NevGi-cpu commented 2 years ago

Thanks for everything. And another thing I noticed when I downloaded 2 or 3 720p anime is that some episodes (1 or 2 eps) were in lower-quality like 360p.

sh1nobuu commented 2 years ago

Thanks for everything. And another thing I noticed when I downloaded 2 or 3 720p anime is that some episodes (1 or 2 eps) were in lower-quality like 360p.

Glad to help! Older anime don't have an HD version therefore the script will download what's available

NevGi-cpu commented 2 years ago

I mean i was able to download 720p quality from gogoanime.pe web though and the anime was for Vinland saga, Majo no tabitabi, gleipnir all dubbed versions of 2021 animes

sh1nobuu commented 2 years ago

I mean i was able to download 720p quality from gogoanime.pe web though and the anime was for Vinland saga, Majo no tabitabi, gleipnir all dubbed versions of 2021 animes

I see thanks for the feedback I'll look into that!

sh1nobuu commented 2 years ago

Updated version of the script is already in the master branch. I will now close this issue.