search

sh33dafi / jest-sonar

A jest reporter that generates sonar reports
MIT License
50 stars 11 forks source link

feat(#36): Respect <rootDir> in outputDirectory #58

Closed swcm-mnestler closed 1 year ago

swcm-mnestler commented 1 year ago

Resolves outputDirectory relative to the jest root directory if it starts with <rootDir>. The implementation was inlined from jest-config.

drjonnicholson commented 1 year ago

Just ran into this problem setting up a monorepo with Lage, so applied these changes locally and it works a charm! Really hoping this gets merged soon 👍

marr commented 1 year ago

Thanks for the PR @swcm-mpilz!

swcm-mnestler commented 1 year ago

Looks like commitlint tried to interpret the #L57-L69 at the end of the link as an issue ref, thus making this part of the commit message a footer. I've adapted the commit message to pass commitlint again

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit eecdb144 and detected 0 issues on this pull request.

View more on Code Climate.

swcm-mnestler commented 1 year ago

Apologies, looks like the husky hooks didn't install correctly for me so prettier was not run against the source. I've rerun prettier, the lint task now passes locally

drjonnicholson commented 1 year ago

@sh33dafi Was this and the corresponding issue intended to be closed as completed? The change doesn't appear to have been merged?

sh33dafi commented 1 year ago

@sh33dafi Was this and the corresponding issue intended to be closed as completed? The change doesn't appear to have been merged?

Should be fixed in 0.2.15 Was indeed not merged

drjonnicholson commented 1 year ago

Confirmed fixed in 0.2.15, thank you @swcm-mnestler and @sh33dafi !