sh4nks / flask-plugins

This extension provides an easy way to create plugins for your flask application.
http://flask-plugins.readthedocs.org/en/latest/
Other
52 stars 21 forks source link

__init__.py fails to consider operating system when setting base_app_folder #10

Closed ghost closed 10 years ago

ghost commented 10 years ago

init.py:185 sets the variable base_app_folder to the application's root_path, splitting out any / characters to get only the last directory's name. However, windows uses \ to denote directories, which causes importlib to fail when it encounters a full path.

When the split character is set to "\", everything else works fine -- either init.py should detect operating system and change the character accordingly, or a more robust mechanism for detecting the root directory should be built (os.path might help abstract this).

EDIT: I'm an idiot, looks like this was fixed a month ago, and is pushed in v1.5. I'll close this now; keep up the good work :)