sh4rkman / SquadCalc

A Minimalist Squad Mortar Calculator
https://squadcalc.app
MIT License
26 stars 2 forks source link

add mk19 rws #149

Open Ferrariic opened 4 weeks ago

Ferrariic commented 4 weeks ago

Example image

Resolves: https://github.com/sh4rkman/SquadCalc/issues/148

sh4rkman commented 1 week ago

Just fyi, i'll be pushing a change in the default gravity use everywhere in calculations, since i came to realisation that the actual gravity use by every calculators (9.8) is probably wrong. In consequence squadmc/squadxyz/squadcalc have been using for years an adapted mortar velocity of 109.89 instead of the 110m/s found in the SDK.

Other weapons didn't get this velocities adaptations and are still using for now the SDK default velocities. That's pretty much unoticable because these weapons have either a wild spread (UB/GRAD) or low velocity (HellCanon). With the M121 high velocity the problem came to light again (see https://github.com/sh4rkman/SquadCalc/issues/156#issuecomment-2192724704)

That should explain why the MK-19 shots were overlapping in your tests and why you felt like correcting the velocity from 240 to 238. You might want to throw some tests again with a new gravity of 9.78 : you'll probably now find that 240 is now the correct value

Ferrariic commented 1 week ago

Rgr that, will do! Allow me some time to make these changes.

Ferrariic commented 1 week ago

Velocity and gravity have been updated to 9.78m/s2 and 237 m/s from 9.8m/s2 and 238 m/s, to incorporate longer flight time with less gravity. I have attempted to use decimal places (ex. 237.5) though I did not notice a major difference.

Testing was performed and can be referenced in issue #148 for four separate states. Additional testing was done though not posted to bring the value down to 237 m/s, ranging confirmed on maps like Talil, Skorpo, etc.

Ferrariic commented 6 days ago

Flight time will have to be incorporated to give correct estimate of range. Refer to: https://github.com/sh4rkman/SquadCalc/issues/163#issuecomment-2198242664.

If squad calc is not build to model off of flight time instead of maximum range, an estimated range could be performed w/ a word of caution to state that shots over 20s will not render.

I will be completely honest, I don't know how to modify squad calc to do that while maintaining your formatting (I am not a front end developer), I'll likely need your help with this @sh4rkman.