search

sh977218 / ts-etl-ui

0 stars 0 forks source link

RequestTime is a Date range #163

Closed ludetc closed 3 months ago

render[bot] commented 3 months ago

Your Render PR Server URL is https://ts-etl-ui-pr-163.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cpu3bgij1k6c73e8ai10.

sh977218 commented 3 months ago

@ludetc When I'm selecting the time, (not click on date), the search API called.

ludetc commented 3 months ago

@ludetc When I'm selecting the time, (not click on date), the search API called.

what do you mean selecting the time but not the date? Are you sure you are not sorting?

sh977218 commented 3 months ago

@ludetc When I'm selecting the time, (not click on date), the search API called.

what do you mean selecting the time but not the date? Are you sure you are not sorting?

see video attached. I think this might be caused by bindQueryParameter directive. Which I remove this in another PR.

https://github.com/sh977218/ts-etl-ui/assets/5692380/96a50ceb-b0ea-4bd9-ba5c-35639c53e922

ludetc commented 3 months ago

@ludetc When I'm selecting the time, (not click on date), the search API called.

what do you mean selecting the time but not the date? Are you sure you are not sorting?

see video attached. I think this might be caused by bindQueryParameter directive. Which I remove this in another PR.

Recording.2024-06-26.182816.mp4

I don't know how to resolve this. When you use the arrow, a new date is selected and so the search is triggers. You can close the date popup, and that will not trigger a search, so something needs to trigger the search. I am not sure there is a solution here.

sh977218 commented 3 months ago

@ludetc When I'm selecting the time, (not click on date), the search API called.

what do you mean selecting the time but not the date? Are you sure you are not sorting?

see video attached. I think this might be caused by bindQueryParameter directive. Which I remove this in another PR. Recording.2024-06-26.182816.mp4

I don't know how to resolve this. When you use the arrow, a new date is selected and so the search is triggers. You can close the date popup, and that will not trigger a search, so something needs to trigger the search. I am not sure there is a solution here.

Yes, you can. I tried to use {updateOn: 'submit'} which require enter key to trigger search, or we can try to do it on blur which require to hover the focus away from input to trigger search.