sh977218 / ts-etl-ui

0 stars 0 forks source link

Activity id is a Date #216

Closed ludetc closed 3 months ago

render[bot] commented 3 months ago

Your Render PR Server URL is https://ts-etl-ui-pr-216.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cq8i8v8gph6c73c6jjvg.

ludetc commented 3 months ago

If they store it as a number, they can transform in API to a date. In the end, it looks like a date on the UI and it should be down to at least seconds for it to be unique.

This solution should do it.

I

On Fri, Jul 12, 2024, 3:13 PM Peter Huang @.***> wrote:

@.**** commented on this pull request.

In server/server.js https://github.com/sh977218/ts-etl-ui/pull/216#discussion_r1675870569:

@@ -201,6 +201,7 @@ app.get('/api/file/:id', (req, res) => {

app.post('/api/loadVersionActivity', async (req, res) => { const { loadVersionsCollection } = await mongoCollection();

  • req.body.loadVersionActivity.id = new Date();

Because this filed in Oracle has to be primary key, I don't think Date type is the primary key, it gotta be a Number

— Reply to this email directly, view it on GitHub https://github.com/sh977218/ts-etl-ui/pull/216#discussion_r1675870569, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA26TSYNISB4PSDVE7JFFSDZL7I7XAVCNFSM6AAAAABKY3L6JOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNZUG42TGOBTGA . You are receiving this because you authored the thread.Message ID: @.***>

sh977218 commented 3 months ago

If they store it as a number, they can transform in API to a date. In the end, it looks like a date on the UI and it should be down to at least seconds for it to be unique. This solution should do it. I On Fri, Jul 12, 2024, 3:13 PM Peter Huang @.> wrote: @*.*** commented on this pull request. ------------------------------ In server/server.js <#216 (comment)>: > @@ -201,6 +201,7 @@ app.get('/api/file/:id', (req, res) => { app.post('/api/loadVersionActivity', async (req, res) => { const { loadVersionsCollection } = await mongoCollection(); + req.body.loadVersionActivity.id = new Date(); Because this filed in Oracle has to be primary key, I don't think Date type is the primary key, it gotta be a Number — Reply to this email directly, view it on GitHub <#216 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA26TSYNISB4PSDVE7JFFSDZL7I7XAVCNFSM6AAAAABKY3L6JOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNZUG42TGOBTGA . You are receiving this because you authored the thread.Message ID: @.>

ok, I'll see when backend API is ready.