Closed GoogleCodeExporter closed 8 years ago
Attaching patch. I wrote the code, it's mine, and I'm contributing it to H2 for
distribution multiple-licensed under the H2 License, version 1.0, and under the
Eclipse Public License, version 1.0 (http://h2database.com/html/license.html).
Some notes:
The implementation accepts the optional third parameter (NLS param), but
currently this parameter has no effect on the behavior of the function.
I removed TO_CHAR from the roadmap HTML file, and I also removed some other
items that have already been implemented.
I put all the logic in a separate ToChar util class -- it just seemed like too
much code to simply add to the Function class.
There are a ton of tests to verify that the function is compatible with
Oracle's TO_CHAR (99% code coverage, I think).
I fixed a small bug in TestBase where if two strings were asserted to be equal
but weren't, then one of the reported lengths was incorrect.
Original comment by djgred...@gmail.com
on 26 Nov 2013 at 10:18
Attachments:
Awesome! Patch committed in revision 5317
Original comment by noelgrandin
on 3 Dec 2013 at 11:57
Original issue reported on code.google.com by
djgred...@gmail.com
on 22 Nov 2013 at 6:12