Feature request "flush queue"

[tbazelczuk]

Hi,

I've found two bugs. Please see below description.

TypeError: Cannot read properties of null (reading 'parentNode')

PositionAnimationsQueue.js:145

case CHANGE_TYPE.move:
                    animatedItem.element = this.view.getPieceElement(Position.indexToSquare(change.atIndex))
                    animatedItem.element.parentNode.appendChild(animatedItem.element) // move element to top layer
                    animatedItem.atPoint = this.view.indexToPoint(change.atIndex)
                    animatedItem.toPoint = this.view.indexToPoint(change.toIndex)
                    break

... and sometimes removeElement has null element

static removeElement(element) {
    if (element.parentNode) {
      element.parentNode.removeChild(element)
    } else {
      console.warn(element, "without parentNode")
    }
  }

[shaack]

Under what circumstances does this occur?

[tbazelczuk]

It happens when you change position frequently with function setPosition

[shaack]

Unfortunately, I can't reproduce this without an example page where the error occurs.

[tbazelczuk]

It happens when you change position during animation.

[tbazelczuk]

I would be nice to setPosition without animation and queue, just reset the board with some initial fen

[shaack]

I can not help you, without an example page. This error does not exist in the demo page or any of my usages.

[tbazelczuk]

Hi, unfortunately I can't reproduce it. I suspect react setState overhead and async events may cause it.

I prepared example how animation queue works when you mouse over on buttons. When you mouse over very quickly and many time the animation is queued. It would be nice to have reset method and cancel queued animations. https://github.com/tbazelczuk/cm-chessboard/blob/example/examples/preview.html

[shaack]

If you can't reproduce it without react, then the failure seems to be in react. I can not give support for react because I don't use it. 🤷‍♂️ The animation queue is a core feature of cm-chessboard, it makes no sense to animate the figures without the queue. However you can switch off animations with a parameter of "setPosition".

[tbazelczuk]

Sure, but resetting the board without any delay would solve the issue. Even if you turn off animation with setPosition cause the problem with stacking animation because all transitions are still in the queue.

[shaack]

In that case this is a feature quest for a "flush queue" feature?

[tbazelczuk]

Right, I think that would solve the issue.

Many thanks :)

[shaack]

Does anyone needs this anymore?

[tbazelczuk]

yes :)

[shaack]

Do you need more a "flush queue", "reset queue" or "stop queue" feature? Is the state of the pieces important after resetting?

[shaack]

Does chessboard.positionAnimationsQueue.stop = true works?