search

shaack / cookie-consent-js

A simple dialog and framework to handle the German and EU law about cookies in a website (December 2021)
MIT License
71 stars 20 forks source link

Adds Occitan locale #3

Closed ensag-dev closed 3 years ago

ensag-dev commented 3 years ago

I hope this is okay and I made all the required changes

shaack commented 3 years ago

OK, nice, thank you.

shaack commented 2 years ago

I removed Occitan again because it's meant to allow you to add your own language via the props.

ensag-dev commented 2 years ago

Hello @shaack , how will people be aware of my contribution then? And the availability of the language?

shaack commented 2 years ago

We could add it as an example on how to add locales/translations via props.

[EDIT] I did it: https://shaack.com/projekte/cookie-consent-js/examples/cookie-consent-add-translations.html

Is that okay with you? We can't include all the languages of the world in the source code, so adding additional languages via props is the preferred way.

shaack commented 2 years ago

Hi, with 2.0.0 I changed the architecture. It now works with language files: https://github.com/shaack/cookie-consent-js/tree/master/cookie-consent-content

Mejans commented 2 years ago

this looks like a good solution, thank you