search

shaack / cookie-consent-js

A simple dialog and framework to handle the German and EU law about cookies in a website (December 2021)
MIT License
71 stars 20 forks source link

scss color variables should be set only if not already present #4

Closed IvanRotrekl closed 2 years ago

IvanRotrekl commented 2 years ago

It would be useful, if sccs variables $primary and $secondary were set with the !default directive:

$primary: #3579F6 !default; // "accept all" button and privacy policy link color
$secondary: #89a !default; // "accept necessary" button color

This way they would not overwrite variables with the same names, which might already exist in a project...

https://github.com/shaack/cookie-consent-js/blob/e35c30980d361935533b128d0618ea1fdca3f23c/src/cookie-consent.scss#L1

shaack commented 2 years ago

Color variables are now more detailed and all !default https://github.com/shaack/cookie-consent-js/blob/master/src/cookie-consent.scss Thanks for reporting.