Open tyler36 opened 1 year ago
Open in CodeSandbox Web Editor | VS Code | VS Code Insiders
The update introduces the capability to specify the locale for Drupal installation, defaulting to English if not defined. It involves setting up environment variables for both the installation profile and locale, and modifying the installation command to utilize these variables. Additionally, the Docker image in the configuration is updated to the latest version, ensuring the use of the most current environment for Drupal development.
Files | Change Summary |
---|---|
.gitpod/.../drupalpod-setup.sh |
Added DP_INSTALL_PROFILE and DP_INSTALL_LOCALE variables, modified ddev drush si command to include --locale option. |
.gitpod.yml |
Updated Docker image reference to drupalpod/drupalpod-gitpod-base:latest . |
๐โจ
In the land of code and web,
Where Drupal pods doth ebb and flow,
A rabbit hopped, a path it wove,
Through locales far and scripts aglow.
"To the latest base," it whispered,
As the environment became bestowed,
With languages rich and diverse,
A global village, together sowed.
๐๐งโจ
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
You have exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 29 minutes and 59 seconds before requesting another review.
To re-trigger a review, convert this PR to a draft and then mark it as ready for review again. Alternatively, you can push a new commit to this PR.
Reset / rebase on main
But this repo has moved to drupal.org right? Shouldn't an MR be there?
@shaal you can easily do a mirroring setup with github actions, but you have to decide where the authoritative code is.
Thank you @rfay The official code is hosted in d.o - https://git.drupalcode.org/project/drupalpod
@shaal could you please make that clear on the README here and archive this one? And please make drupalpod.com go to the Drupal.org one?
The Problem/Issue/Bug
Drupal defaults to English locale.
How this PR Solves The Problem
This PR allows the user to set Drupal's locale via an ENV.
drush si
is run with the locale being set toDP_INSTALL_LOCALE
.DP_INSTALL_LOCALE
defaults to English(`en') if not set.No attempts are made to validate the locale code passed to drush.
Manual Testing Instructions
Ideally, we should be able to pass the variable via the URL similar to
DP_INSTALL_PROFILE
. I'm sure if its that simple though.Ideally, the browser extension would be updated to allow user to enter/select the locale. However, having it as a "undocumented" feature is fine until "full" support is required.
Related Issue Link(s)
Release/Deployment notes
Summary by CodeRabbit
New Features
DP_INSTALL_LOCALE
environment variable, defaulting to "en" if not specified.Chores