shaal / DrupalPod

Start Drupal contributions with 1 click.
https://shaal.github.io/DrupalPod
MIT License
163 stars 54 forks source link

Drupal locale set via ENV #113

Open tyler36 opened 1 year ago

tyler36 commented 1 year ago

The Problem/Issue/Bug

Drupal defaults to English locale.

How this PR Solves The Problem

This PR allows the user to set Drupal's locale via an ENV.

drush si is run with the locale being set to DP_INSTALL_LOCALE. DP_INSTALL_LOCALE defaults to English(`en') if not set.

No attempts are made to validate the locale code passed to drush.

Manual Testing Instructions

Ideally, we should be able to pass the variable via the URL similar to DP_INSTALL_PROFILE. I'm sure if its that simple though.

Ideally, the browser extension would be updated to allow user to enter/select the locale. However, having it as a "undocumented" feature is fine until "full" support is required.

Related Issue Link(s)

Release/Deployment notes

Summary by CodeRabbit

codesandbox[bot] commented 1 year ago

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

ghost commented 1 year ago
๐Ÿ‘‡ Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/shaal/DrupalPod/113/9b5c35eb/e5a864f9c0177b058ae430e02e1f8eb395b10d5e.svg)](https://app.codesee.io/r/reviews?pr=113&src=https%3A%2F%2Fgithub.com%2Fshaal%2FDrupalPod) #### Legend CodeSee Map legend
coderabbitai[bot] commented 11 months ago

Walkthrough

The update introduces the capability to specify the locale for Drupal installation, defaulting to English if not defined. It involves setting up environment variables for both the installation profile and locale, and modifying the installation command to utilize these variables. Additionally, the Docker image in the configuration is updated to the latest version, ensuring the use of the most current environment for Drupal development.

Changes

Files Change Summary
.gitpod/.../drupalpod-setup.sh Added DP_INSTALL_PROFILE and DP_INSTALL_LOCALE variables, modified ddev drush si command to include --locale option.
.gitpod.yml Updated Docker image reference to drupalpod/drupalpod-gitpod-base:latest.

๐Ÿ‡โœจ
In the land of code and web,
Where Drupal pods doth ebb and flow,
A rabbit hopped, a path it wove,
Through locales far and scripts aglow.
"To the latest base," it whispered,
As the environment became bestowed,
With languages rich and diverse,
A global village, together sowed.
๐ŸŒ๐Ÿ”งโœจ


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
coderabbitai[bot] commented 11 months ago

Rate Limit Exceeded

You have exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 29 minutes and 59 seconds before requesting another review.

To re-trigger a review, convert this PR to a draft and then mark it as ready for review again. Alternatively, you can push a new commit to this PR.

tyler36 commented 6 months ago

Reset / rebase on main

rfay commented 2 weeks ago

But this repo has moved to drupal.org right? Shouldn't an MR be there?

@shaal you can easily do a mirroring setup with github actions, but you have to decide where the authoritative code is.

shaal commented 2 weeks ago

Thank you @rfay The official code is hosted in d.o - https://git.drupalcode.org/project/drupalpod

rfay commented 2 weeks ago

@shaal could you please make that clear on the README here and archive this one? And please make drupalpod.com go to the Drupal.org one?