shaal / DrupalPod

Start Drupal contributions with 1 click.
https://shaal.github.io/DrupalPod
MIT License
163 stars 54 forks source link

Minor cleanup as the years go by (docker-compose version, etc) #119

Closed rfay closed 1 year ago

rfay commented 1 year ago

The Problem/Issue/Bug

I just took a quick pass through and noted a few things like needing to remove version from docker-compose

Summary by CodeRabbit

codesandbox[bot] commented 1 year ago

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders
Open Preview

coderabbitai[bot] commented 1 year ago

Walkthrough

This pull request primarily focuses on updating the DDEV setup for a Drupal 9 project, including PHP, MariaDB, and Node.js versions. It also introduces performance optimization strategies and modifies service ports. A new chromedriver service is added to the testing configuration.

Changes

File Path Summary
.ddev/config.yaml Updates PHP, MariaDB, and Node.js versions; optimizes performance; modifies service ports.
.ddev/docker-compose.ports.yaml Removes version declaration and adjusts indentation of services block.
.ddev/docker-compose.testing.yaml Removes version number and adds a new chromedriver service using drupalci/chromedriver:production image.

🐇💻

In the land of code, where logic intertwines,

The rabbit hops, through lines and lines.

With each leap forward, an update unfurls,

In the world of Docker, where the data whirls.

PHP, MariaDB, Node.js too,

Updated versions, shiny and new.

Chromedriver joins the merry band,

As we hop along, paw in hand. 🎉

Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - Mention `@coderabbitai` in any *review comment* for bot assistance. - Note: Review comments are made on code diffs or files, not on the PR overview. ### Pause Incremental Reviews - Insert `@coderabbitai: ignore` in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
ghost commented 1 year ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/shaal/DrupalPod/119/9e04bc51/485b9a5715dd76e187101139fce22a4cb371bbaa.svg)](https://app.codesee.io/r/reviews?pr=119&src=https%3A%2F%2Fgithub.com%2Fshaal%2FDrupalPod) #### Legend CodeSee Map legend
shaal commented 1 year ago

Thank you @rfay I added this update to https://github.com/shaal/DrupalPod/pull/123