shaal / DrupalPod

Start Drupal contributions with 1 click.
https://shaal.github.io/DrupalPod
MIT License
163 stars 54 forks source link

Please use default LTS version of MariaDB (10.4) #125

Closed rfay closed 11 months ago

rfay commented 11 months ago

The Problem/Issue/Bug

Currently it's wired to Mariadb 10.3, but current LTS is 10.4, also DDEV default

How this PR Solves The Problem

Change to 10.4

Note that this was done in

Which you said you incorporated, but somehow it got lost.

Summary by CodeRabbit

codesandbox[bot] commented 11 months ago

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders
Open Preview

coderabbitai[bot] commented 11 months ago

Walkthrough

This pull request primarily focuses on upgrading the MariaDB database version from 10.3 to 10.4 in both DDEV and Gitpod configurations. Additionally, it introduces an empty web_environment list and updates the composer_version to "2" in the DDEV configuration.

Changes

File Path Summary
.ddev/config.yaml Upgraded MariaDB version from 10.3 to 10.4, added an empty web_environment list, and updated composer_version to "2".
.gitpod/.../create-environments.sh Updated the MariaDB version from 10.3 to 10.4 in the DDEV configuration.

🐇💻

With a hop and a skip, we upgrade our ship,

From MariaDB ten point three, to four with glee.

Composer two now joins the crew,

And an empty list makes its debut.

So here's to changes, big and small,

May they make our code stand tall! 🎉🥕

Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - Mention `@coderabbitai` in any *review comment* for bot assistance. - Note: Review comments are made on code diffs or files, not on the PR overview. ### Pause Incremental Reviews - Insert `@coderabbitai: ignore` in the PR description to halt the bot's ongoing reviews. Remove the line to resume. - Additionally, enter `@coderabbitai pause` to halt the bot's ongoing reviews as any issue or review comment. To resume reviews, enter `@coderabbitai resume` as any issue or review comment.
ghost commented 11 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/shaal/DrupalPod/125/72a72101/b64dd4bda0a94c0721cbe145e1de0b14146c8282.svg)](https://app.codesee.io/r/reviews?pr=125&src=https%3A%2F%2Fgithub.com%2Fshaal%2FDrupalPod) #### Legend CodeSee Map legend
shaal commented 11 months ago

Fixed by PR https://github.com/shaal/DrupalPod/pull/133