shaal / DrupalPod

Start Drupal contributions with 1 click.
https://shaal.github.io/DrupalPod
MIT License
163 stars 54 forks source link

Use less complicated method to download images #126

Closed rfay closed 1 year ago

rfay commented 1 year ago

The Problem/Issue/Bug

Currently there's a complex script to do the download, but it really only requires two lines

How this PR Solves The Problem

Use the two lines.

Summary by CodeRabbit

codesandbox[bot] commented 1 year ago

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders
Open Preview

coderabbitai[bot] commented 1 year ago

Walkthrough

The update optimizes the Docker image download process for DDEV by leveraging the ddev debug download-images command. It also narrows down the focus to pull only the necessary drupalci/chromedriver:production image, enhancing efficiency.

Changes

File Summary
.gitpod/utils/download-ddev-images.sh The script has been updated to use ddev debug download-images for downloading Docker images. It now specifically pulls the drupalci/chromedriver:production image, improving efficiency and focus.

🐇

In the land of code, where the shadows lie,

An update comes, swift as a dragonfly.

With a hop and a skip, it makes its way,

Optimizing downloads, saving the day.

No more pulling images, one by one,

With ddev, our task is quickly done.

And in the heart of Docker, there's a new guest,

drupalci/chromedriver, simply the best! 🚀

Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - Mention `@coderabbitai` in any *review comment* for bot assistance. - Note: Review comments are made on code diffs or files, not on the PR overview. ### Pause Incremental Reviews - Insert `@coderabbitai: ignore` in the PR description to halt the bot's ongoing reviews. Remove the line to resume. - Additionally, enter `@coderabbitai pause` to halt the bot's ongoing reviews as any issue or review comment. To resume reviews, enter `@coderabbitai resume` as any issue or review comment.
ghost commented 1 year ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/shaal/DrupalPod/126/3f171ccc/c48a9d3091bde460740bc4650a3776fdc11aa79b.svg)](https://app.codesee.io/r/reviews?pr=126&src=https%3A%2F%2Fgithub.com%2Fshaal%2FDrupalPod) #### Legend CodeSee Map legend
shaal commented 1 year ago

Fixed by PR https://github.com/shaal/DrupalPod/pull/133