shaal / DrupalPod

Start Drupal contributions with 1 click.
https://shaal.github.io/DrupalPod
MIT License
163 stars 54 forks source link

add symlink only at end of process #134

Closed shaal closed 1 year ago

shaal commented 1 year ago

Summary by CodeRabbit

codesandbox[bot] commented 1 year ago

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders
Open Preview

coderabbitai[bot] commented 1 year ago

Walkthrough

The changes primarily focus on improving the setup process for Drupal projects in Gitpod. The setup scripts have been modularized into separate files, each handling a specific part of the setup process such as composer setup, Drupal core setup, and Drupal contrib setup. This makes the code more maintainable and easier to understand. Additionally, the scripts now handle different types of Drupal projects and create symlinks for projects without a composer.json file.

Changes

File Summary
.../drupalpod-setup/composer_setup.sh Adds a script that sets up the composer.json and composer.lock files, fixes Composer 2.2 allow-plugins configuration, and adds the project source code as a symlink.
.../drupalpod-setup/drupal_setup_contrib.sh Adds a script that creates a symlink for Drupal projects without a composer.json file based on the DP_PROJECT_TYPE variable. It also modifies the composer configuration and adds the project as a dependency.
.../drupalpod-setup/drupal_setup_core.sh Adds a script that sets up composer repositories, creates symbolic links, and creates folders for running tests.
.../drupalpod-setup/drupalpod-setup.sh Modifies the main setup script to include the new setup scripts, checks if the project directory exists before cloning it, and modifies the composer configuration.
.../drupal/install-essential-packages.sh Modifies a script to apply different actions based on the value of the DP_PROJECT_TYPE variable, including patching files, adding a project as a symlink, and running different scripts.

🐇💻

"In the land of code where the shadows lie,

We've made some changes, oh me, oh my!

Setup's now modular, clean, and spry,

Making Drupal sing, under Gitpod's sky.

Symlinks for projects, no composer.json? No cry!

With these changes, we aim high,

To the moon, our code will fly!" 🚀🌕


Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - Mention `@coderabbitai` in any *review comment* for bot assistance. - Note: Review comments are made on code diffs or files, not on the PR overview. ### Pause Incremental Reviews - Insert `@coderabbitai: ignore` in the PR description to halt the bot's ongoing reviews. Remove the line to resume. - Additionally, enter `@coderabbitai pause` to halt the bot's ongoing reviews as any issue or review comment. To resume reviews, enter `@coderabbitai resume` as any issue or review comment.
ghost commented 1 year ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/shaal/DrupalPod/134/b0d6f141/48c193fc3314d53585ff143bc2c70dd78aba0fb4.svg)](https://app.codesee.io/r/reviews?pr=134&src=https%3A%2F%2Fgithub.com%2Fshaal%2FDrupalPod) #### Legend CodeSee Map legend