search

shaansubbaiah / Portfolio

👤 Automatically generate and deploy a beautiful, responsive, static-site to display your GitHub projects.
MIT License
82 stars 13 forks source link

Serve github avatar from own assets #29

Closed tomhooijenga closed 4 years ago

tomhooijenga commented 4 years ago

This should fix #24

shaansubbaiah commented 4 years ago

@tomhooijenga Thanks! Yet to test but there seem to be no issues.

Could you also allow the user to choose a custom picture instead of their GitHub profile picture? I had mentioned in my comment earlier.

Similar to the other config options, we'd have to ask the user if they want to load a custom picture and if they decide not to, use the GitHub profile picture. The custom picture location would be stored in config.json

tomhooijenga commented 4 years ago

I can have a look at that. Do we want to support both local and hosted/remote images?

shaansubbaiah commented 4 years ago

Not sure, but for now I think just local is fine. Just make sure the user is aware that only local image paths can be supplied. However, if you want to make it support both, you can do that instead.

shaansubbaiah commented 4 years ago

Tested, works well. Love that it now shows previous config values. Merged :smile: