search

shaansubbaiah / Portfolio

👤 Automatically generate and deploy a beautiful, responsive, static-site to display your GitHub projects.
MIT License
82 stars 13 forks source link

Move utitlity functions to /utils #32

Closed shaansubbaiah closed 3 years ago

shaansubbaiah commented 3 years ago

Currently getData.js, getAvatar.js, and build.js are in the repository root directory. Move them to a new folder utils. This should keep the repo more organized.

Guzzler commented 3 years ago

i could pick this up but would like to recommend maybe a better restructure of the files. would that be possible @shaansubbaiah ?

shaansubbaiah commented 3 years ago

Hey @Guzzler, I think @hafizmuhammadshoaib has attempted a fix but hasn't yet changed the paths in the files. We'll wait for him to fix that, if not you can take it up.

How do you recommend that we restructure the project better?

Guzzler commented 3 years ago

just doing a basic overview of the code you want restructured i would recommend changing the build file to actually use smaller helpers instead of a large chain of ifs for each if statement as well as have the getAvatar and getData both renamed and put in a singular util file as they use alot of similar imports. We can keep the build at the root since that is usually something required to be used regularly when changed. These are just a few changes from my first impressions. Do let me know what you think @shaansubbaiah