shaansubbaiah / Portfolio

👤 Automatically generate and deploy a beautiful, responsive, static-site to display your GitHub projects.
MIT License
82 stars 13 forks source link

Move functions to /utils #33

Closed hafizmuhammadshoaib closed 4 years ago

shaansubbaiah commented 4 years ago

You haven't modified the paths, results in an error while building.

█▀█ █▀█ █▀█ ▀█▀ █▀▀ █▀█ █░░ █ █▀█
█▀▀ █▄█ █▀▄ ░█░ █▀░ █▄█ █▄▄ █ █▄█
https://github.com/shaansubbaiah/Portfolio

1. Set Github Token 
2. Set configuration options 
3. Build Portfolio 
4. Exit 
Choice: 3

Starting Build
[Error: ENOENT: no such file or directory, open '/home/shaan/Github/Portfolio/utils/config.json'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/home/shaan/Github/Portfolio/utils/config.json'
}
[Error: ENOENT: no such file or directory, open '/home/shaan/Github/Portfolio/utils/config.json'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/home/shaan/Github/Portfolio/utils/config.json'
}
⚠️ Failed!
Error: Cannot read property 'username' of undefined
shaansubbaiah commented 4 years ago

I think even the config.json will be created in /utils instead of the root directory, which has to be fixed.

hafizmuhammadshoaib commented 4 years ago

Okay doing it

hafizmuhammadshoaib commented 4 years ago

pushed commit

hafizmuhammadshoaib commented 4 years ago

@shaansubbaiah please review the PR.

shaansubbaiah commented 4 years ago

Tested, config.json still gets created in the utils/ directory.

I think you have modified it to read the config at Portfolio/utils/config.json, it should instead create it at Portfolio/config.json and read it from there.

hafizmuhammadshoaib commented 4 years ago

okay will do it.

shaansubbaiah commented 4 years ago

Can you also remove the formatting changes L40-41, L130-131, L272-273. I'm currently using Prettier to format JS, I'll add it to the repo after this PR.

hafizmuhammadshoaib commented 4 years ago

i have solved the conflicts

hafizmuhammadshoaib commented 4 years ago

i am also using prettier

shaansubbaiah commented 4 years ago

Tested, works well! Thanks. Merging.