shaarli / Shaarli

The personal, minimalist, super-fast, database free, bookmarking service - community repo
https://shaarli.readthedocs.io/
Other
3.41k stars 291 forks source link

[Feature Request] Tools option for 'privacy.force_login' #1456

Open lonix1 opened 4 years ago

lonix1 commented 4 years ago

The tools menu allows us to update the app's config to config.json.php.

Most "important" options are available via the UI, but not the privacy.force_login option.

lonix1 commented 4 years ago

For anyone else who wants this, I noticed that when I installed the material theme, it also added some extra features.

One such feature was this config option.

ArthurHoaro commented 4 years ago

This is intended. We try to keep only major settings in the UI, to avoid having an overloaded settings page.

I don't think this one setting is a major one. However, if this is needed, we can consider having an « Advanced settings » mode to include a bunch of currently hidden settings.

lonix1 commented 4 years ago

I think it's very important - if you want to setup the app securely, you need two settings:

privacy.hide_public_links
privacy.force_login

They are probably amongst the most important settings. If you want to secure the app so only you can use it (which I assume is what many (/most?) do), then you need to set both options.

But, an "advanced" section is a good idea!