Closed AlphaJack closed 10 months ago
nodiscc
commented
1 year ago Thanks for reporting this. I will try to reproduce it. This is the diff between 51603fe and master: https://github.com/shaarli/Shaarli/compare/51603fe265b796a4f7a6037b44518988addfcd46...master (49 commits).
Which Installation method did you use? (from source + composer? Docker). More details on installation steps you performed are welcome.
AlphaJack
commented
1 year ago Thank you, I installed from source, you can find the steps here: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=shaarli-git
PHP enabled extensions:
extension=gd
extension=gettext
extension=intl
extension=ldapPHP-FPM pool config:
[www]
user = http
group = http
listen = /run/php-fpm/php-fpm.sock
listen.owner = http
listen.group = http
pm = dynamic
pm.max_children = 5
pm.start_servers = 2
pm.min_spare_servers = 1
pm.max_spare_servers = 3Ideally I would like to install Shaarli in a dedicate container, but unfortunately the Dockerhub image does not ship in arm64 architecture (see #1496)
nodiscc
commented
1 year ago Function strftime() is deprecated
This is expected since strftime() is deprecated as of PHP 8.1.0 (https://www.php.net/manual/en/function.strftime.php) and is still used in multiple places (it was already present in 51603fe265b796a4f7a6037b44518988addfcd46)
~/GIT/Shaarli (master $=)$ git grep -n strftime
application/Utils.php:347: return strftime('%B', $date->getTimestamp());
tpl/vintage/daily.html:41: {function="strftime('%A %d, %B %Y', $day)"}
tpl/vintage/daily.html:61: <a href="{$base_path}/shaare/{$value.shorturl}">{function="strftime('%c', $link.timestamp)"}</a>everything works fine, even with PHP 8.2
Are you sure it does? This deprecation warning should be present with PHP 8.1 and 8.2, regardless of Shaarli version.
(These warnings should not prevent Shaarli from working correctly. In the mean time, if you want to get rid of the warnings, you can either stick with PHP 8.0 which is supported until November 2023 or disable reporting of deprecation warnings in your PHP configuration.)
AlphaJack
commented
1 year ago Are you sure it does? This deprecation warning should be present with PHP 8.1 and 8.2, regardless of Shaarli version.
I get this:
| PHP 8.1 | PHP 8.2 | |
|---|---|---|
| Shaarli 2269 | Warning | Warning |
| Shaarli 2318 | Not tried | Error |
Only with "Error" the website is broken
nodiscc
commented
11 months ago @AlphaJack do you still have this problem with the latest release?
I am running Shaarli v0.12.2 on PHP 8.2.7-1~deb12u1 without problems.
nodiscc
commented
10 months ago I can't reproduce this either with the setup mentioned above (deployment from release zip + PHP 8.2 on Debian), or with the latest docker image which uses PHP 8.2.
Feel free to reopen this issue if the problem is still present.
By updating shaarli to the latest commit (number: 2318, hash: ab16f6a8) from the previous commit it has been built (number: 2269, hash: 51603fe2) I am getting the following issues:
If I rebuild shaarli against the previous commit, everything works fine, even with PHP 8.2