shaarli / Shaarli

The personal, minimalist, super-fast, database free, bookmarking service - community repo
https://shaarli.readthedocs.io/
Other
3.4k stars 287 forks source link

Move back API documentation to the main repository, update HTML export tooling #1999

Open nodiscc opened 1 year ago

nodiscc commented 1 year ago

Followup to https://github.com/shaarli/Shaarli/pull/1997

Is there any reason why the api documentation is separated from the main documentation? It would be appreciable to have both at the same location

I'd also prefer it to be moved to the main repo. There is no actual reason other than (I guess) being able to use the https://shaarli.github.io/api-documentation/ URL on Github pages. I think that could be worked around easily (keep https://github.com/shaarli/api-documentation an empty repository, and have Shaarli's main repository CI push to the gh-pages branch there). Or maybe just regroup it with https://shaarli.readthedocs.io/?

Maintaining documentation across 2 repositories is painful and causes the API documentation repo to be neglected/forgotten about. We should try to find a way to move the API documentation back to https://github.com/shaarli/Shaarli/tree/master/doc, while keeping the HTML output on https://shaarli.github.io/api-documentation/

nodiscc commented 1 year ago

In addition:

and also to stop using aglio.js, as the last commit was in 2018

Actually the API documentation repo has been neglected since 2020, it still uses our old Travis CI account which stopped working about a year ago. I'm not sure the documentation itself is up to date, your PR to expose tags_separator just reminded me that this repo existed. As you noticed, the documentation renderer (aglio) is also unmaintained. We should move to another generator that supports the API blueprint source format.

nodiscc commented 1 year ago

We should move to another generator that supports the API blueprint source format.

The only remaining HTML renderers for the API blueprint format appear to be:

nodiscc commented 10 months ago

https://sphinxcontrib-httpdomain.readthedocs.io/en/stable/ - Sphinx domain for documenting HTTP APIs

nodiscc commented 4 months ago

Due to all this I'll unassign myself from this issue. The main problem IMHO is the API documentation repo being separated from the main repo, and the broken CI tooling (the HTML documentation is no longer updated when we commit to the API docs repo).

We need to carefully consider what our options are:

/cc @ArthurHoaro @virtualtam