search

shaarli / Shaarli

The personal, minimalist, super-fast, database free, bookmarking service - community repo
https://shaarli.readthedocs.io/
Other
3.41k stars 287 forks source link

Tag entry field is too small #235

Closed nodiscc closed 9 years ago

nodiscc commented 9 years ago

shaarli

This happens since https://github.com/shaarli/Shaarli/commit/4c68c20cdd2baec36c03aa6237d2d932605b6252

nicolasdanelon commented 9 years ago

Yes, my fault. Sorry for small pulls with poor testing. I'm with this now. But we need to move the CSS to OOCSS Just because this can not happen again. I'll work on OOCSS ASAP too. OOCSS = one "class" for structure, one "class" for styling.

ArthurHoaro commented 9 years ago

I didn't know OOCSS, that's an interesting concept. However, it's probably a lot of work with this 1K lines CSS file.

nicolasdanelon commented 9 years ago

No no, is not about that, it's about avoid a big CSS file! but we need to rewrite some html structures.. and the whole CSS. OOCSS was born in 2008 when people write big stylesheets and was hard to edit and add new styles. If we turn shaarli CSS code into this technique we won't have this issues again

nodiscc commented 9 years ago

As discussed with @mrjovanovic in https://github.com/shaarli/Shaarli/issues/174, proposing a new default template would be welcome, I think. A simple responsive grid system (https://thisisdallas.github.io/Simple-Grid/ or other) could be used, along with best webdev practices.

We should still fix the current stylesheet for now.

nodiscc commented 9 years ago

Not fixed http://shaarlidemo.tuxfamily.org/Shaarli/?post= edit: wait, the demo is not up to date with master edit2: fixed