Refactor HTTP / Url functions - Githubissues

shaarli / Shaarli

The personal, minimalist, super-fast, database free, bookmarking service - community repo

https://shaarli.readthedocs.io/

Other

3.4k stars 287 forks source link

Refactor HTTP / Url functions #333

Closed virtualtam closed 8 years ago

virtualtam commented 9 years ago

Relates to #332

Todolist

move to application/HttpUtils.php (#334, #346):
- [x] ~~http_parse_headers_shaarli()~~ => use get_headers()
- [x] getHTTP () => get_http_url()
- [x] serverUrl()
- [x] indexUrl()
- [x] pageUrl()
add test coverage
apply coding conventions

[EDIT 2015-11-09] Moved to #372 -Introduce a Shaarli class:

move to ?

[ ] checkUpdate() => shaarli_check_update()

possibly application/ShaarliUtils.php:

other option: introduce a Shaarli class to hold config / version management

nicolasdanelon commented 8 years ago

Awesome work!