Twitter video won't work with bookmarklet

shaarli / Shaarli

The personal, minimalist, super-fast, database free, bookmarking service - community repo

https://shaarli.readthedocs.io/

Other

3.43k stars 293 forks source link

Twitter video won't work with bookmarklet #958

Closed Nono-m0le closed 7 years ago

Nono-m0le commented 7 years ago

Hi Team,

Not sure if it's a bug or on purpose but I can't share this link using the bookmaklet : https://twitter.com/i/videos/tweet/841902425581719552 Is it the same reason why we can't share github links ?

thewilli commented 7 years ago

@Nono-m0le what exactly does not work for you? What web browser and Shaarli version are you using?

I tried the following steps using the current Firefox und Chrome version and the recent Shaarli master branch, and did not encounter any error:

Open the link from you
Click on bookmarklet, add the bookmark using it
Open Shaarli in a new tab
Click on the recently added bookmark
The original site is loaded again. Everything seem to work :smiley:

ArthurHoaro commented 7 years ago

I doesn't for me either due to CSP (also Firefox reports errors related to CSP).

There is nothing we can do about it though.

@thewilli did you disable CSP settings in your browsers?

thewilli commented 7 years ago

@ArthurHoaro

@thewilli did you disable CSP settings in your browsers?

I'm using the FF dev edition, maybe there is an active setting to disable it. My Chrome is the regular macOS version 60, and passes the CSP test, but the Bookmarklet works, even with Github. Strange 😶

ArthurHoaro commented 7 years ago

It does work in Chrome, and not yet in the regular FF version. The issues I linked for both browsers aren't fixed yet, but I guess it's going to the right direction. In any case, that's not related to Shaarli itself.