shaarli / netscape-bookmark-parser

PHP library to parse Netscape bookmark files
https://packagist.org/packages/shaarli/netscape-bookmark-parser
MIT License
22 stars 10 forks source link

Refactor the parser in a single NetscapeBookmarkParser class #14

Closed virtualtam closed 8 years ago

virtualtam commented 8 years ago

Modifications:

virtualtam commented 8 years ago

Ping @ArthurHoaro & @nodiscc , as this parser should be mature enough to be used within Shaarli ;-)

ArthurHoaro commented 8 years ago

Great! :+1: I've asked a few question about how it handles tags, but almost ready.

Also we'll have to be careful about empty URL and default timestamp with Shaarli integration.

virtualtam commented 8 years ago

Thanks for the review!

Regarding Shaarli-specific formatting:

I think it'd also be worth simplifying the parser's cleanup steps, all those regexes feel a bit superfluous (=> separate PR)

ArthurHoaro commented 8 years ago

Permalinks are fine, we have to support it, to move a Shaarli to another for example. I was talking about this one.

virtualtam commented 8 years ago

I was talking about this one.

Hmm, I wouldn't worry too much about "linkless links", the only way one would end with this is by manually editing a bookmark dump and deleting the href attribute, which is kinda silly...

virtualtam commented 8 years ago

To sum up: