search

shaarli / netscape-bookmark-parser

PHP library to parse Netscape bookmark files
https://packagist.org/packages/shaarli/netscape-bookmark-parser
MIT License
22 stars 10 forks source link

[feature] Parsing 'ICON' attribute #70

Closed TangoMan75 closed 3 years ago

TangoMan75 commented 3 years ago

1. New feature

parseString method now returns and array containing a new icon property :

[
  "uri" => "https://discord.com/"
  "icon" => "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8..."
  "title" => "Discord"
  "note" => "foobar"
  "tags" => [
        "bookmarks",
        "bar",
  ]
  "time" => 1592775139
  "pub" => false
]

2. Unit tests

Updated associated unit test.

3. Semantics

Renamed some variables inside parseString method: eg: $m1 => $href, $m2 => $title...

This is mostly for semantics, and will not impact behavior in any way.

4. gitignore

Added .phpcs-cache in .gitignore

ArthurHoaro commented 3 years ago

Why do you re-open a PR for each change though?

TangoMan75 commented 3 years ago

You're welcome... :-) I'm not sure it would include latest commits and rebase... Would it ?

ArthurHoaro commented 3 years ago

Yep Github picks up everything pretty well, even if you force push.