search

shaarli / netscape-bookmark-parser

PHP library to parse Netscape bookmark files
https://packagist.org/packages/shaarli/netscape-bookmark-parser
MIT License
22 stars 10 forks source link

[BC breaking] Remove Katzgrau-KLogger dependency #72

Closed TangoMan75 closed 3 years ago

TangoMan75 commented 3 years ago

TRUE_PATTERN and FALSE_PATTERN

"yes" appearing twice in string. Reordered attributes alphabetically.

Remove dependency on Katzgrau\KLogger

Replaced with psr/log in composer.json Class no longer implements LoggerAwareInterface. Logger is optional and can be injected. Removed setLogger method. Removed idle TestCase.php. Removed idle LoggerTestUtils from tests.

TangoMan75 commented 3 years ago

Hey Arthur!

Are you still interested in my PR ?

If breaking changes are too disruptive, I suppose we can work around it.

  1. I can keep the signature of the original class unchanged, but flag for deprecation.
  2. Push changes.
  3. And then remove it on the next release.

?

ArthurHoaro commented 3 years ago

Hi! Yes, sorry, I didn't work on Shaarli these days and kinda forgot about this PR.