Change ESLint rule requiring line breaks at 72/n chars

shabados / actions

Cross-repository utilities repository

MIT License

0 stars 4 forks source link

Change ESLint rule requiring line breaks at 72/n chars #5

Closed bhajneet closed 3 years ago

bhajneet commented 4 years ago

Since most viewers/editors can wrap lines in 2020, we probably don't need the eslint rule forcing us to make line breaks in our source code. This also helps with generating docs from source code without single line breaks.

Originally posted by @bhajneet & @Harjot1Singh in https://github.com/ShabadOS/gurmukhi-utils/pull/150

Harjot1Singh commented 3 years ago

I think we should keep the line break rule - it's not about line wrapping, it's just overall a better visual experience and encourages better practice to keep code lines shorter and more succinct

bhajneet commented 3 years ago

Should create an issue to fix gurmukhi utils readme being generated with short lines since they're line broken comments

bhajneet commented 3 years ago

Actually it renders fine on GitHub, just looks a bit odd in source code. Not a big deal.