search

shabados / database

A digital representation of Sikh Bani and other Panthic texts with a public logbook of sangat-sourced corrections.
https://docs.shabados.com/database
GNU General Public License v3.0
63 stars 23 forks source link

Refactor Banis into "Bookmarks" #1393

Open bhajneet opened 4 years ago

bhajneet commented 4 years ago

A "breaking" change, so on hold

See #1389 for more info

sarabveer commented 4 years ago

I don't think "Bookmarks" belong in the Database, it should be up to the app developer to include them in their apps (ie. Desktop)

bhajneet commented 4 years ago

@Harjot1Singh We can just delete bookmarks/banis from db then. Let front end developers figure it out. Since desktop is open source they can easily see the lines they may need to use in their bookmarks/banis too based on our bookmarks.

sarabveer commented 4 years ago

Wouldn't #1389 fix this issue without breaking?

Harjot1Singh commented 4 years ago

No, because we'd still have to rename the table

sarabveer commented 4 years ago

It still wouldn't be "Bookmarks", that's out of scope for the DB and is supposed to be on the app side.

If anything, the table still could be called banis, but in #1389, we would have a gutka instead of isBani

sarabveer commented 3 years ago

It still wouldn't be "Bookmarks", that's out of scope for the DB and is supposed to be on the app side.

If anything, the table still could be called banis, but in #1389, we would have a gutka instead of isBani

Looking back at this, I have changed my mind. Bookmarks is fine if isBani from #1389 is added.