search

shabados / database

A digital representation of Sikh Bani and other Panthic texts with a public logbook of sangat-sourced corrections.
https://docs.shabados.com/database
GNU General Public License v3.0
63 stars 24 forks source link

ASCII Gurmukhi is incorrect for some records in database? #1876

Closed onkarjit closed 2 years ago

onkarjit commented 2 years ago

Describe the bug

When searching for the record with the id KP7D in the lines table, and looking at the gurmukhi column for that record it says: gauVI kbIr jI pMcpdy₂ ]

There is a subscript ₂ character in the ASCII Gurmukhi. 

const {
    toUnicode,
} = require( 'gurmukhi-utils' )

const asciiGurmukhi = 'gauVI kbIr jI pMcpdy₂ ]';
console.log(toUnicode( asciiGurmukhi ) );

When Gurmukhi Utils converts it to unicode, it parses the subscript ₂ literally.

It outputs:

ਗਉੜੀ ਕਬੀਰ ਜੀ ਪੰਚਪਦੇ₂ ॥

The subscript ₂ character shouldn't be there as we can see when we view the same shabad line at SikhiToTheMax.

I am using SQLite ShabadOS database, to be specific Release 4.8.0.

bhajneet commented 2 years ago

In these instances, you may view the original sources. There are links available in our docs citations. As you'll see the original data contains these characters.

https://docs.shabados.com/database/source-material

When trying to decide what is "right", the recommended course from us is to lookup the original sources and match them.

Closing this as working as intended. Please let us know if you have any other questions.